This repository was archived by the owner on Apr 8, 2021. It is now read-only.
Add escalation ids to services #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alexturek
reviewed
Sep 9, 2020
Co-authored-by: Alex Turek <[email protected]>
cordway
force-pushed
the
add_escalation_ids_to_services
branch
from
b29e4d3 to
b63bfc9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add escalation policy id
escalation_idto the services table.The point of this PR is to enable joining of the
servicesandescalation_policiestable onescalation_id. This is helpful in being able to easily determine the escalation policy of a service. Right now it is only possible to get a services escalation policy by going through a particular incident (joiningservicesandincidentsandincidentsandescalation_policies). This is not entirely reliable as services policies can be changed. Addingescalation_idis only a few lines change as the ID is easily available in the JSON response from the pagerduty api.Locally verified, able to create tables & load data with
escalation_idnow present in services table.